Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove property after zero #586

Closed
muuvmuuv opened this issue Jun 27, 2018 · 3 comments
Closed

Do not remove property after zero #586

muuvmuuv opened this issue Jun 27, 2018 · 3 comments

Comments

@muuvmuuv
Copy link

I got this code with a grid value:

.class {
      grid-template-columns: 1fr 0fr 0;
    }

and when I fix the code with csscomb I get this:

.class {
      grid-template-columns: 1fr 0 0;
    }

csscomb deletes the fr from my value, how can I prevent this?

@b13nxx
Copy link

b13nxx commented Dec 1, 2018

In your .csscomb.json set this option:

{
    "unitless-zero": false
}

@muuvmuuv
Copy link
Author

muuvmuuv commented Dec 1, 2018

Pretty smooth for a workaround but I think it shouldnt remove it no matter false or true

Sent with GitHawk

@b13nxx
Copy link

b13nxx commented Dec 1, 2018

For me, its better to have option instead of default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants