Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New options: Spaces before and after selector delimiters #196

Closed
wants to merge 3 commits into from
Closed

New options: Spaces before and after selector delimiters #196

wants to merge 3 commits into from

Conversation

vecmezoni
Copy link
Contributor

Fixes: #51

@tonyganch tonyganch added the purr label Mar 10, 2014
@@ -15,9 +15,11 @@
"space-after-colon": " ",
"space-after-combinator": " ",
"space-after-opening-brace": "\n",
"space-after-selector-delimiter": "\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mishanga, I need your opinion on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonyganch, it might be

    "space-after-selector-delimiter": " ",

I just followed my company styleguide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it as it already is.

@vecmezoni
Copy link
Contributor Author

@tonyganch, should i rename the options?
#92 (comment)

@tonyganch
Copy link
Member

@vecmezoni, not sure.
I haven't thought of delimiter until now, it seems to be not a bad idea.
In some preprocessor languages delimiter can not necessarily be a comma: it can be a semicolon, for example, though the function/meaning is almost the same.

This way options can be named:

  • space-after-selector-delimiter (space after comma in selector);
  • space-after-argument-delimiter (space after comma/semicolon in function/mixin/include);
  • space-after-declaration-delimiter (space after semicolon between declarations).

/cc @mishanga @kizu

@kizu
Copy link
Contributor

kizu commented Mar 11, 2014

I think delimiter is ok. In Stylus, for example, you can omit the comma if you delimit the lines using newline, so delimiter would be better there than comma. And there are many similar places in Stylus (and in other ident-based preprocessors, I guess).

@mishanga
Copy link
Contributor

I like delimiter too.

@tonyganch
Copy link
Member

Merged into dev.
@vecmezoni, thank you!
🐙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for whitespaces around the comma in selectors
4 participants