Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jss-global] Don't publish .babelrc to npm #673

Closed
Vanuan opened this issue Jan 29, 2018 · 7 comments
Closed

[jss-global] Don't publish .babelrc to npm #673

Vanuan opened this issue Jan 29, 2018 · 7 comments
Labels
bug It went crazy and killed everyone. complexity:low You can fix it, c'mon! plugin When unplugged is fine

Comments

@Vanuan
Copy link

Vanuan commented Jan 29, 2018

There's this new bundler, called Parcel. Its behavior relies on .babelrc file published to npm package. If it finds one, it tries to run babel on entrypoint provided in main with the configuration provided in .babelrc. Babel plugins are included in devDependencies section of package.json which are not being installed, so it fails.

Please, publish only files that are necessary for inclusion.

@kof
Copy link
Member

kof commented Jan 29, 2018

Yep, I need to change that for all repos, using files field in package json instead of .npmignore

@iamstarkov
Copy link
Member

@Vanuan why does parcel behaves this way?

@Vanuan
Copy link
Author

Vanuan commented Jan 30, 2018

@iamstarkov You should ask its author :) There's an ongoing discussion here: parcel-bundler/parcel#13

It looks like Parcel author tries to establish a practice of publishing source code to npm along with instructions to build it. .babelrc heuristics is just the simplest implementation.

@kof
Copy link
Member

kof commented Jan 30, 2018

This is ultimately wrong from parcel, it uses babelrc config from a project it doesn't own but doesn't install the required dependencies of that project. In any case I probably should not publish the babelrc, so I don't care why they do what they do.

@iamstarkov
Copy link
Member

in other words, what did parcel expect?

@AleshaOleg
Copy link
Member

#961

@TrySound
Copy link
Member

This is fixed via package.json files field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It went crazy and killed everyone. complexity:low You can fix it, c'mon! plugin When unplugged is fine
Projects
None yet
Development

No branches or pull requests

5 participants