Bugfix/dynamic rules redeploy #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounting a React component with dynamic values
This was referenced Sep 11, 2019
kof
reviewed
Sep 11, 2019
kof
reviewed
Sep 12, 2019
|
Nice work! |
HenriBeck
approved these changes
Sep 14, 2019
|
Please add a changelog entry; then we could release this as this fixes quite an important bug |
…les and sheet.renderer
|
released 10.0.0-alpha.25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What would you like to add/fix?
Dynamic rules stop working after sheet re-attach via React component unmount/mount.
Corresponding issue (if exists):
#1187
Details
I’ve added a check in
DomRendererso that thethis.hasInsertedRulesworkaround doesn’t force a redeploy if the sheet was going to redeploy too, by checkingthis.sheet.deployed.