Add warning when using a function value inside a function rule #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
reviewed
Feb 25, 2020
| @@ -55,6 +56,13 @@ export default function functionPlugin() { | |||
| // Empty object will remove all currently defined props | |||
| // in case function rule returns a falsy value. | |||
| styleRule.style = fnRule(data) || {} | |||
|
|
|||
| for (const prop in styleRule.style) { | |||
There was a problem hiding this comment.
We could avoid doing these checks in production by wrapping it in if (process.env.NODE_ENV === 'development')
There was a problem hiding this comment.
Then we could even avoid warning package and use only console.warn.
There was a problem hiding this comment.
I would keep warning for consistency, but it doesn't matter technically, just in case in the future we want to replace warning, it will be easier if it's used consistently
kof
requested changes
Feb 25, 2020
|
@kof updated! I had to change |
|
LGTM, thank you! |
|
released in 10.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue (if exists):
#1057
What would you like to add/fix?
Add warning when user tries to use a function value inside a function rule.
Todo