Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tiny-warning to deps #1315

Merged
merged 1 commit into from
Mar 16, 2020
Merged

add tiny-warning to deps #1315

merged 1 commit into from
Mar 16, 2020

Conversation

dgreuel
Copy link
Contributor

@dgreuel dgreuel commented Mar 16, 2020

Corresponding issue (if exists): #1313

What would you like to add/fix? add tiny-warning to deps for jss-plugin-rule-value-function to avoid yarn PnP errors

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

@dgreuel dgreuel requested a review from HenriBeck as a code owner March 16, 2020 15:01
@kof
Copy link
Member

kof commented Mar 16, 2020

did you add it with yarn add? lock file isn't updated

@dgreuel
Copy link
Contributor Author

dgreuel commented Mar 16, 2020

did you add it with yarn add? lock file isn't updated

Yes, did yarn add tiny-warning@^1.0.2. The entry is already in the lockfile

@kof kof merged commit 3f35178 into cssinjs:master Mar 16, 2020
@kof
Copy link
Member

kof commented Mar 16, 2020

merged, thanks!

@mciparelli
Copy link

packages like @material-ui/styles depend on jss-plugin-rule-value-function directly, which hasn't been bumped yet. Could you release a new version of jss-plugin-rule-value-function that contains tiny-warning dependency?

@gamb
Copy link

gamb commented Apr 23, 2020

@kof I can put up a release PR if helpful? As @mciparelli mentions ☝️

arcanis added a commit to yarnpkg/berry that referenced this pull request Jun 1, 2020
…dency to extensions (#1424)

* Add jss-plugin-rule-value-function to extensions

See cssinjs/jss#1315.

* Versions

Co-authored-by: Maël Nison <nison.mael@gmail.com>
@cypher-1999
Copy link

Is the issue solved my project is stuck??

@kof
Copy link
Member

kof commented Jun 3, 2020

Released in v10.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants