fix(react-jss): fix react-jss theme types

[vismu]

What would you like to add/fix?

The problem is that my app Theme interface didn't match to unknown theme type.
So I think any type would be better in this case.

[vismu]

Hello, dear colleagues!
Any updates here?
I still have an issue with matching Theme interface to unknown type.

Maybe any advices how to do it in a right way.

[kof]

Is this the best way to do it in ts? Is user able to define a strict theme? It sounds like it should be a generic but I only use flowtype, so I have no idea
cc @moshest can you advise us here pls?

[vismu]

Is this the best way to do it in ts? Is user able to define a strict theme? It sounds like it should be a generic but I only use flowtype, so I have no idea
cc @moshest can you advise us here pls?

Of course we can add second generic for WithStylesProps to specify theme object in more strict way.

interface WithStylesProps<S extends Styles | ((theme: T) => Styles), T> {
  classes: Classes<S extends ((theme: T) => Styles) ? keyof ReturnType<S> : keyof S>
}

But, actually, we don't need this Theme generic to calculate our classes result.
So it will be a little bit overhead and do the usage more annoying.

interface Props extends WithStylesProps<typeof styles, Theme> {}

vs

interface Props extends WithStylesProps<typeof styles> {}

[kof]

Mb I misunderstand something, is user able to specify the theme type right now and let ts show this type everywhere it is used?

[vismu]

In my app I have a Theme interface and use it while defining of dynamic styles for component.

const styles = (theme: Theme) => {...}

[moshest]

I agree.

We should change theme type to any:

//                                                    ↧ this one
interface WithStylesProps<S extends Styles | ((theme: any) => Styles)> {
  classes: Classes<S extends ((theme: any) => Styles) ? keyof ReturnType<S> : keyof S>
}

[kof]

Alright, merged!

[vismu]

Alright, merged!

Great! Can you tell me how frequently new versions of react-jss are published.