Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extend): extends multiple named styles (fix #1345) #1357

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

fi3ework
Copy link
Member

Corresponding issue (if exists):

#1345

What would you like to add/fix?

Now plugin can extend both named and object in the array.

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

@fi3ework fi3ework requested a review from HenriBeck as a code owner June 22, 2020 17:26
@kof
Copy link
Member

kof commented Jun 28, 2020

Hey, LGTM, missing docs and changelog and we are good to go

@fi3ework
Copy link
Member Author

Hi @kof, thanks for replying. Should I execute yarn version and bump a patch version? contributing.md did not list how to update changelog independently.

@kof
Copy link
Member

kof commented Jun 29, 2020

@fi3ework no, just add the info where needed in /docs and add the changelog affter --- in changelog.md, like the rest of the file

@fi3ework
Copy link
Member Author

@kof Done, please review again. 😆

@kof kof merged commit 4382ef5 into cssinjs:master Jun 29, 2020
@kof
Copy link
Member

kof commented Jun 29, 2020

merged, thank you!

@kof
Copy link
Member

kof commented Aug 14, 2020

released in 10.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants