-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade flow to 0.138.0 #1425
Upgrade flow to 0.138.0 #1425
Conversation
rollup.config.js
Outdated
@@ -59,7 +59,20 @@ const commonjsOptions = { | |||
// https://github.com/rollup/rollup-plugin-commonjs#custom-named-exports | |||
// https://github.com/reduxjs/react-redux/issues/643#issuecomment-285008041 | |||
namedExports: { | |||
react: ['Component', 'createContext'] | |||
react: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is becoming annoying, especially if someone new tries to use a function from react and don't know about this whitelist.
I don't know exactly why, but it started failing in react-jss package and ssaying those are not exported, demanding to add them
Any ideas @TrySound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref #1425 (comment) In the new version namedExports is no longer required. Brand new synthetic exports solves the problem.
Ref #1425 (comment) In the new version namedExports is no longer required. Brand new synthetic exports solves the problem.
@TrySound seems like I got after the upgrade of rollup weird flow issues, seems like flow is not seeing the types from import any more, you might already know what that is
|
Fixed. Missed this. |
Omg I would have died trying to fix it lol
…On Sun, Nov 15, 2020, 13:48 Bogdan Chadkin ***@***.***> wrote:
Fixed. Missed this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1425 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAM4WATCOL2HQ6W45X6OPTSP7E3HANCNFSM4TVE7XBQ>
.
|
.flow files were missing |
No description provided.