Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flow to 0.138.0 #1425

Merged
merged 5 commits into from
Nov 15, 2020
Merged

Upgrade flow to 0.138.0 #1425

merged 5 commits into from
Nov 15, 2020

Conversation

kof
Copy link
Member

@kof kof commented Nov 13, 2020

No description provided.

@kof kof requested a review from HenriBeck as a code owner November 13, 2020 23:29
rollup.config.js Outdated
@@ -59,7 +59,20 @@ const commonjsOptions = {
// https://github.com/rollup/rollup-plugin-commonjs#custom-named-exports
// https://github.com/reduxjs/react-redux/issues/643#issuecomment-285008041
namedExports: {
react: ['Component', 'createContext']
react: [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is becoming annoying, especially if someone new tries to use a function from react and don't know about this whitelist.

I don't know exactly why, but it started failing in react-jss package and ssaying those are not exported, demanding to add them

Any ideas @TrySound

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TrySound added a commit that referenced this pull request Nov 13, 2020
Ref #1425 (comment)

In the new version namedExports is no longer required. Brand new
synthetic exports solves the problem.
@TrySound TrySound mentioned this pull request Nov 13, 2020
3 tasks
kof pushed a commit that referenced this pull request Nov 14, 2020
Ref #1425 (comment)

In the new version namedExports is no longer required. Brand new
synthetic exports solves the problem.
@kof
Copy link
Member Author

kof commented Nov 15, 2020

@TrySound seems like I got after the upgrade of rollup weird flow issues, seems like flow is not seeing the types from import any more, you might already know what that is

Importing a type from an untyped module makes it any and is not safe! Did you mean to add // @flow to the top of jss?
[untyped-type-import]

     1│ // @flow
     2│ /* eslint-disable no-use-before-define */
     3│ import warning from 'tiny-warning'
     4│ import type {Plugin} from 'jss'
     5│
     6│ const isObject = obj => obj && typeof obj === 'object' && !Array.isArray(obj)
     7│ const valueNs = `extendCurrValue${Date.now()}`

@TrySound
Copy link
Member

Fixed. Missed this.

@kof
Copy link
Member Author

kof commented Nov 15, 2020 via email

@TrySound
Copy link
Member

.flow files were missing

@kof kof merged commit 207f48b into master Nov 15, 2020
@kof kof deleted the upgrade-flow branch November 15, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants