Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate withStyles to use hooks #1508

Merged
merged 14 commits into from
Jun 27, 2021
Merged

Migrate withStyles to use hooks #1508

merged 14 commits into from
Jun 27, 2021

Conversation

kof
Copy link
Member

@kof kof commented Apr 28, 2021

Corresponding Issue(s): #1506

Todo

  • Add test(s) that verify the modified behavior
  • Add documentation if it changes public API

Expectations on Changes

Changelog

@kof kof mentioned this pull request Apr 28, 2021
behnammodi and others added 4 commits June 27, 2021 12:22
* remove noTheme

* remove unused type

* style: match imported name as same to other files

* perf: we do not need initial createUseStyle inside component

* clean code

* rebase and clean up

* fix flow issue

* fix(withStyle): remove any type

* fix(withStyle): ship any to union
@kof kof merged commit 372e9c1 into master Jun 27, 2021
@kof kof deleted the behnammodi-refactor-withStyles branch June 27, 2021 10:47
@kof
Copy link
Member Author

kof commented Jun 27, 2021

merged 🎉 thank you!

@kof
Copy link
Member Author

kof commented Jun 27, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants