Keep classes ref when sheet and dynamicRules have not any change

[behnammodi]

What Would You Like to Add/Fix?

getSheetClasses always return new object even sheet and dynamicRules haven't any change

Also I wrote a small test to keep it in future

Todo

• Add test(s) that verify the modified behavior

Expectations on Changes

So, I memoized it to prevent this behavior

Changelog

Improve performance at useStyle

[behnammodi]

@kof Thanks for review, all of them is done

[behnammodi]

@kof This is ready to merge

[kof]

@behnammodi thanks, will look into it, in the meantime, please test it in your app in production and let me know if you notice anything

[behnammodi]

@behnammodi thanks, will look into it, in the meantime, please test it in your app in production and let me know if you notice anything

Sure, I'll tell you

[behnammodi]

@kof I build react-jss then I created a pack and install on our project everything works very well

[behnammodi]

@kof I found a better solution, please see this file packages/react-jss/src/createUseStyles.js changes

[behnammodi]

@kof This PR ready to merge and main change is:

-    const classes = sheet && dynamicRules ? getSheetClasses(sheet, dynamicRules) : emptyObject
+    const classes = React.useMemo(
+      () => (sheet && dynamicRules ? getSheetClasses(sheet, dynamicRules) : emptyObject),
+      [sheet, dynamicRules]
+    )

not anymore

[kof]

looks great now, thank you

[kof]

released in v10.9.0