Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-jss] Add flow typings #818

Merged
merged 27 commits into from Aug 15, 2018
Merged

[react-jss] Add flow typings #818

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b4b0523
First commit
gomesalexandre Aug 7, 2018
e008910
Fixes on createHOC and injectSheet
gomesalexandre Aug 8, 2018
bd5348a
More fixes on createHOC and injectSheet
gomesalexandre Aug 8, 2018
887652f
Better flow typings on createHOC
gomesalexandre Aug 10, 2018
3954fc5
Moved types/index.js just to types.js and added InnerProps and OuterP…
Aug 11, 2018
a7cca18
Simplified typings of injectSheet.js
Aug 11, 2018
b379272
Updated and fixed some typings in createHOC.js
Aug 11, 2018
b1fb062
Removed unnecessary types in ns.js
Aug 12, 2018
1d69fce
Added flow flag to some untyped files
Aug 12, 2018
0c07422
Exporting StyleSheetFactoryOptions now instead of StyleSheetOptions
Aug 12, 2018
386f2e5
Fix typing of getDisplayName
Aug 12, 2018
839e1ae
Added Context Type and updated Options to use StyleSheetFactoryOption…
Aug 12, 2018
fccbbf0
Moved types/index.js just to types.js and added
Aug 12, 2018
5f1c1e8
Improved Context Type
Aug 12, 2018
d867aa2
Updated createHoc to use Context type
Aug 12, 2018
539c3ed
Improved typing of the Theming option
Aug 12, 2018
bacb6bd
Formatted code with prettier
Aug 12, 2018
2b86b8d
Updated size snapshot and lockfile
Aug 12, 2018
ecdf147
Make options in injectSheet optional an default it to an empty object
Aug 12, 2018
4c16374
Fixed types of the JssProvider props
Aug 12, 2018
3ad6097
Remove semi eslint rule
Aug 12, 2018
1a803f9
Removed unnecessary types
Aug 14, 2018
44d7dd5
Remove unnecessary check
Aug 14, 2018
9da04d3
Updated a if statement and fixed removing dynamic sheet from global r…
Aug 14, 2018
3d7d984
Fixed naming of some type names to always start with an uppercase char
Aug 15, 2018
fcd4345
Renamed generic types of createHOC
Aug 15, 2018
629d9f5
Merge branch 'master' into react-jss-flow-typings
Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc
View file
Open in desktop
Expand Up @@ -4,7 +4,8 @@
"rules": {
"import/no-unresolved": 0,
"flowtype/define-flow-type": 1,
"flowtype/use-flow-type": 1
"flowtype/use-flow-type": 1,
"semi": ["error", "never"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use spaces instead of tabs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be reverted anyway because prettier takes care of it. I actually write the code with semicolons and prettier removes them for me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yes, definetly spaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the indent rule would avoid such issue, I have automatic linting fixes on save in VSCode. Plus we would get errors thrown within the hook, should I add it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also run prettier in the precommit git hook so it's unnecessary

},
"globals": {
"benchmark": true,
Expand Down