Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve withTheme #61

Merged
merged 8 commits into from
Oct 27, 2018
Merged

Improve withTheme #61

merged 8 commits into from
Oct 27, 2018
+109 −61

Conversation

HenriBeck
Copy link
Member

  • Removed support for renaming the prop (we can't type it)
  • Added support for innerRef
  • Added support for forwarding the innerRef to the wrapped component

@HenriBeck HenriBeck requested a review from kof October 26, 2018 10:01
kof
kof approved these changes Oct 27, 2018
View reviewed changes
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HenriBeck HenriBeck merged commit 6a59e0f into master Oct 27, 2018
@HenriBeck HenriBeck deleted the remove-support-for-renaming-prop branch October 27, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HenriBeck @kof