Exported ThemeProviderProps #67
Merged
+570
−631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenriBeck
requested changes
Nov 1, 2018
|
Do you really need the export? I think it would be simpler by just setting the |
|
I like the contract between the component and the theme provider, to ensure the property is set from the ThemeProvider and not set by the user. |
|
Okay, can you then also export the same type factory for flow? We should keep the types aligned as much as possible |
HenriBeck
approved these changes
Nov 2, 2018
HenriBeck
approved these changes
Nov 2, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests supports that you are able to use
ThemeProviderPropsin your components.