fix(postcss-merge-rules): do not merge conflicting flex properties

`place` conflicts with `justify` and `align`, even if they don't start with the same property.
cssnano · Feb 15, 2023 · b69b8e9 · b69b8e9
1 parent 2e89321
commit b69b8e9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/packages/postcss-merge-rules/src/index.js b/packages/postcss-merge-rules/src/index.js
@@ -163,8 +163,9 @@ function isConflictingProp(propA, propB) {
   if (!a.base && !b.base) {
     return true;
   }
-  // Different base;
-  if (a.base !== b.base) {
+
+  // Different base and none is `place`;
+  if (a.base !== b.base && a.base !== 'place' && b.base !== 'place') {
     return false;
   }
 

diff --git a/packages/postcss-merge-rules/test/index.js b/packages/postcss-merge-rules/test/index.js
@@ -372,6 +372,14 @@ test(
   )
 );
 
+test(
+  'should not incorrectly extract flex properties',
+  processCSS(
+    '.a { place-content: center; justify-content: start; } .b { justify-content: start; place-content: center; }',
+    '.a { place-content: center; } .a,.b { justify-content: start; } .b { place-content: center; }'
+  )
+);
+
 test(
   'should not incorrectly extract display properties',
   passthroughCSS(