-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: invalid border shorthand with custom properties #1354
Labels
Projects
Comments
the "lite" preset seems to handle this correctly |
1 task
Duplicate of #675
The lite preset disables declaration merging completely. You can also disable this optimisation in the default preset. |
ludofischer
added a commit
that referenced
this issue
Mar 11, 2022
Fix #1354 Fix #675 - postcss-merge-longhand first 'explodes' longhand declarations to the smallest unit (for example border-width -> border-top-width). If the declaration value contains a custom property, it is not possible to safely explode width/size/color, as the custom property might be equivalent to multiple space-separated values. - this plugin lowercases property names as a side-effect of exploding, so to preserve the old behaviour we lowercase the property that cannot be exploded - remove incorrect tests and add tests for new behaviour
ludofischer
added a commit
that referenced
this issue
Mar 11, 2022
Fix #1354 Fix #675 - postcss-merge-longhand first 'explodes' longhand declarations to the smallest unit (for example border-width -> border-top-width). If the declaration value contains a custom property, it is not possible to safely explode width/size/color, as the custom property might be equivalent to multiple space-separated values. - this plugin lowercases property names as a side-effect of exploding, so to preserve the old behaviour we lowercase the property that cannot be exploded - remove incorrect tests and add tests for new behaviour
ludofischer
added a commit
that referenced
this issue
Mar 11, 2022
Fix #1354 Fix #675 - postcss-merge-longhand first 'explodes' longhand declarations to the smallest unit (for example border-width -> border-top-width). If the declaration value contains a custom property, it is not possible to safely explode width/size/color, as the custom property might be equivalent to multiple space-separated values. - this plugin lowercases property names as a side-effect of exploding, so to preserve the old behaviour we lowercase the property that cannot be exploded - remove incorrect tests and add tests for new behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
the following:
results in (default preset):
which is invalid.
Expected behaviour
when a custom property is encountered, don't collapse border properties into shorthand.
Steps to reproduce
Version
whatever is currently on the cssnano playground, 5.1.0 probably
Preset
default
Environment
Package details
Additional context
No response
The text was updated successfully, but these errors were encountered: