Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postcss-ordered-values): columns transform returning string instead of the AST #928

Merged
merged 3 commits into from
Aug 1, 2020
Merged

fix(postcss-ordered-values): columns transform returning string instead of the AST #928

merged 3 commits into from
Aug 1, 2020

Conversation

anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Jul 30, 2020 •
edited
Loading

Fixes #927

postcss-order-values when transforming the columns was returning ASTs instead of string

@anikethsaha anikethsaha changed the title fix: added checks for prop value changes as AST is being changed by plugins fix(postcss-ordered-values): columns transform returning string instead of the AST Jul 31, 2020
@anikethsaha
Copy link
Member Author

cc @evilebottnawi fixed the root cause

alexander-akait
alexander-akait approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks!

@anikethsaha anikethsaha merged commit a5d6d36 into cssnano:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] : Using grid/column syntax breaks compilation
2 participants
@anikethsaha @alexander-akait