fix: update SVGO #1016
Merged
fix: update SVGO #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludofischer
commented
Mar 14, 2021
| ) | ||
| ); | ||
|
|
||
| test( | ||
| 'should optimise inline svg in base64', | ||
| processCSS( | ||
| "h1{background:url('data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz48IURPQ1RZUEUgc3ZnIFBVQkxJQyAiLS8vVzNDLy9EVEQgU1ZHIDEuMS8vRU4iICJodHRwOi8vd3d3LnczLm9yZy9HcmFwaGljcy9TVkcvMS4xL0RURC9zdmcxMS5kdGQiPjxzdmcgdmVyc2lvbj0iMS4xIiBpZD0iTGF5ZXJfMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayIgeG1sOnNwYWNlPSJwcmVzZXJ2ZSI+PGNpcmNsZSBjeD0iNTAiIGN5PSI1MCIgcj0iNDAiIGZpbGw9InllbGxvdyIgLz48IS0tdGVzdCBjb21tZW50LS0+PC9zdmc+')}", | ||
| "h1{background:url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxjaXJjbGUgY3g9IjUwIiBjeT0iNTAiIHI9IjQwIiBmaWxsPSIjZmYwIi8+PC9zdmc+')}" | ||
| "h1{background:url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbDpzcGFjZT0icHJlc2VydmUiPjxjaXJjbGUgY3g9IjUwIiBjeT0iNTAiIHI9IjQwIiBmaWxsPSIjZmYwIi8+PC9zdmc+')}" |
There was a problem hiding this comment.
Keeping xml:space="preserve" also causes the base64 output changes. Check:
echo IHhtbDpzcGFjZT0icHJlc2VydmUi | base64 -d -
| ) | ||
| ); | ||
|
|
||
| test( | ||
| 'should optimise inline svg (uppercase property)', | ||
| processCSS( | ||
| 'h1{background:URL(\'data:image/svg+xml;utf-8,<?xml version="1.0" encoding="utf-8"?><!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"><svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xml:space="preserve"><circle cx="50" cy="50" r="40" fill="yellow" /><!--test comment--></svg>\')}', | ||
| 'h1{background:URL(\'data:image/svg+xml;charset=utf-8,<svg xmlns="http://www.w3.org/2000/svg"><circle cx="50" cy="50" r="40" fill="%23ff0"/></svg>\')}' | ||
| 'h1{background:URL(\'data:image/svg+xml;charset=utf-8,<svg xmlns="http://www.w3.org/2000/svg" xml:space="preserve"><circle cx="50" cy="50" r="40" fill="%23ff0"/></svg>\')}' |
There was a problem hiding this comment.
According to the SVGO commit log, removing xml:space="preserve" was a bug svg/svgo@776ec1e
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
==========================================
- Coverage 97.60% 97.59% -0.01%
==========================================
Files 116 116
Lines 3589 3579 -10
Branches 1059 1059
==========================================
- Hits 3503 3493 -10
Misses 79 79
Partials 7 7
Continue to review full report at Codecov.
|
ludofischer
force-pushed
the
update-svgo
branch
from
ec40d27
to
5426c62
Compare
ludofischer
force-pushed
the
update-svgo
branch
from
4721542
to
ca0fc92
Compare
TrySound
reviewed
Mar 14, 2021
ludofischer
force-pushed
the
update-svgo
branch
2 times, most recently
from
5ebf890
to
feecb04
Compare
TrySound
reviewed
Mar 15, 2021
* Update SVGO dependency * Refactor plugin to use new SVGO API * Refactor test to use new SVGO API * Update test since removing xml:space="preserve" was an SVGO bug * Update documentation since SVGO is now synchronous
ludofischer
force-pushed
the
update-svgo
branch
from
feecb04
to
dbc08bf
Compare
alexander-akait
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVGO bug