refactor(postcss-merge-longhand): remove css-color-names dep #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
css-color-names is a JSON file with a mapping from color name to hex: 1. we don't use the hex code 2. CSS4 color spec says color names are not recommended, so unlikely new color names will be added 3. even if we need to add a color, it is easier to add it ourselves than to open a PR upstream 4. css-color-names sources the color names from w3schools instead of the spec 5. css-color-names is not future-proof because it exports a JSON file
ludofischer
commented
Nov 12, 2021
| 'white', | ||
| 'whitesmoke', | ||
| 'yellow', | ||
| 'yellowgreen', |
There was a problem hiding this comment.
There are 148 colors (150 - 1 comment line - 1 export line) as expected.
Codecov Report
@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
- Coverage 96.54% 96.54% -0.01%
==========================================
Files 116 116
Lines 3616 3615 -1
Branches 1064 1064
==========================================
- Hits 3491 3490 -1
Misses 117 117
Partials 8 8
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
css-color-names is a JSON file with a mapping from color name to hex:
so unlikely new color names will be added
than to open a PR upstream