-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cssnano-preset-default): update css-declaration-sorter #1521
Conversation
Will fix the TS error soonish, I'll have to publish another version bump. |
c909e2a
to
07346d5
Compare
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Fixed the regression with commonjs types resolution, ready for review! |
07346d5
to
2ad41fc
Compare
7.1.0 includes a fix to not change the order of unknown properties to avoid mixing unknown shorthand and longhand properties. Closes cssnano#1514
2ad41fc
to
f62589c
Compare
Did you look at the changes in the CSS files to make sure they look as expected? I know it can be quite annoying to inspect those diffs. |
@ludofischer yes I've looked through them, to be honest there is one unexpected change in blueprint css where E.g.
|
There are other changes I do not understand. For example, why does |
@ludofischer sorry for the late reply, I'm back from vacation and took some time to get used to life & work rhythm. It's an odd change, could it be the combination of other modules causing this? If I add a test it passes: test(
'keep order',
passthroughCSS('html{-ms-text-size-adjust:100%;-webkit-text-size-adjust:100%;font-family:sans-serif}')
); |
It's odd indeed. Do any unwanted consequences come to mind? How could it be other modules if nothing changed in this PR except css-declaration-sorter? |
Hi, I've reapplied the changes myself in a different branch because a SVGO upgrade in-between had caused too many conflicts in the CSS files |
Ah I see thank you @ludofischer, sorry for not replying been busy again. |
7.1.0 includes a fix to not change the order of unknown properties to
avoid mixing unknown shorthand and longhand properties.
Closes #1514
Because the snapshots contain some experimental properties which are not included in the sorter I've updated them.