Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests looping toInitial.json data should run #1572

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

colinrotherham
Copy link
Contributor

This PR fixes the Promise.all() calls in packages/postcss-reduce-initial/test/index.js so they resolve

Promise.all([
processCSS(t, `${property}:${value}`, `${property}:initial`, {
env: 'chrome58',
}),
passthroughCSS(t, `${property}:${value}`, { env: 'ie6' }),
]);

Two property tests for 'writing-mode' and 'transform-box' failed but these were handled in:

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (6f9fa98) to head (492800b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1572   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         123      124    +1     
  Lines       10325    10328    +3     
=======================================
+ Hits        10077    10080    +3     
  Misses        248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

colinrotherham added a commit to colinrotherham/cssnano that referenced this pull request Mar 4, 2024
colinrotherham added a commit to colinrotherham/cssnano that referenced this pull request Mar 4, 2024
@colinrotherham
Copy link
Contributor Author

@ludofischer Rebased to resolve the conflict 👍

@ludofischer ludofischer merged commit ae14108 into cssnano:master Mar 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants