fix(postcss-minify-selectors): quotes are removed even when attribute selector escaping was required #1627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1530
This PR fixes it by using
cssesc
to additionally check if escaping is needed, and not stripping quotes when escaping is needed.This PR adds
cssesc
as a dependency, but since it is already a dependency ofpostcss-selector-parser
, it is not effectively adding a new dependency.