Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postcss-minify-selectors): quotes are removed even when attribute selector escaping was required #1627

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

ota-meshi
Copy link
Contributor

Fix #1530

This PR fixes it by using cssesc to additionally check if escaping is needed, and not stripping quotes when escaping is needed.

This PR adds cssesc as a dependency, but since it is already a dependency of postcss-selector-parser, it is not effectively adding a new dependency.

Copy link
Collaborator

@ludofischer ludofischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! There's a cssnano OpenCollective where you could try to claim some money for your contributions, although unfortunately there's only a few hundred dollars available per year.

@ludofischer ludofischer merged commit d6339c8 into cssnano:master Jun 9, 2024
9 of 10 checks passed
@ota-meshi ota-meshi deleted the fix1530 branch June 9, 2024 11:09
@ota-meshi
Copy link
Contributor Author

I'm grateful that cssnano is continuously maintained! I don't require payment from cssnano 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Case insensitive attribute selector is escaped incorrectly
2 participants