Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postcss-ordered-values): incorrect order when using calc for animation property #1629

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ota-meshi
Copy link
Contributor

This PR fixes postcss-ordered-values ​​to track units in math functions, fixing the incorrect ordering of animation property.

Fix #1527

Copy link
Collaborator

@ludofischer ludofischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! May I ask why you decided to work on this particular fix? Did you also encounter the issue? I thought it would be relatively rare because it required turning off the calc plugin.

@ludofischer ludofischer merged commit f16db94 into cssnano:master Jun 10, 2024
10 checks passed
@ota-meshi ota-meshi deleted the issue1527 branch June 10, 2024 15:30
@ota-meshi
Copy link
Contributor Author

Thank you for checking the pull request!

I haven't had any problems with issues other than the ones I posted. Other than that, I've only been working on issues labeled as bug where the method to reproduce was clear. Therefore, I don't expect you to rush to check the pull requests 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: calc in the animation property value swaps duration and delay with the "calc" setting turned off
2 participants