Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests are published to NPM registry #879

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Unit tests are published to NPM registry #879

merged 2 commits into from
Mar 19, 2020

Conversation

koresar
Copy link
Contributor

@koresar koresar commented Feb 17, 2020

@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #879 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files         118      118           
  Lines        3455     3455           
  Branches     1037     1037           
=======================================
  Hits         3361     3361           
  Misses         86       86           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde2080...d8616fc. Read the comment docs.

@anikethsaha
Copy link
Member

is there any other packages having this same mistake ?

@koresar
Copy link
Contributor Author

koresar commented Feb 20, 2020

From cssnano project? I don't know.

@koresar
Copy link
Contributor Author

koresar commented Feb 20, 2020

I actually checked the source code of about 10 of them. It was good there. I even copied the lines from them for this PR. 😀

@anikethsaha
Copy link
Member

checking the package.json.files should be fine !

@anikethsaha anikethsaha merged commit 09bdf86 into cssnano:master Mar 19, 2020
@koresar koresar deleted the patch-1 branch March 23, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants