Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: writing-mode: initial != horizontal-tb #905

Closed
wants to merge 2 commits into from

Conversation

@codecov-io
Copy link

codecov-io commented May 7, 2020

Codecov Report

Merging #905 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         118      118           
  Lines        3458     3458           
  Branches     1040     1040           
=======================================
  Hits         3364     3364           
  Misses         86       86           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd5c44...7e2c4f9. Read the comment docs.

@anikethsaha
Copy link
Member

initial for writing-mode is horizontal-tb ref this

@ICELI
Copy link
Author

ICELI commented May 8, 2020

initial for writing-mode is horizontal-tb ref this

First of all, thanks for such a quick reply.
Yes, I know that. But in that case, they did behave inconsistently in the Chrome browser. How do I solve it, give up chrome or cssnano, is there an easy way to solve this problem.

@ICELI
Copy link
Author

ICELI commented May 8, 2020

In version 81 of the Chrome browser, this can be solved as follows:

-webkit-writing-mode: horizontal-tb;
     writing-mode: initial;

But in the Chrome 83 (beta) version, it does not work.

https://codepen.io/ICELI/pen/bGVvBro

@anikethsaha
Copy link
Member

Thanks for the details 👍 ,
We are using caniuse-api to check the support, it is working as expected.
perhaps, you can change the version in browserlist config for chrome and try,
also,
we don't want to move away from official specs. So personally I would wait until there is any changes in the spec.

in the meantime, you can

@anikethsaha anikethsaha added the Working as Intended The issue/report is working as expected to its design label Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Working as Intended The issue/report is working as expected to its design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants