Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace jshint + jscs by eslint #104

Closed
MoOx opened this issue Apr 27, 2015 · 8 comments
Closed

replace jshint + jscs by eslint #104

MoOx opened this issue Apr 27, 2015 · 8 comments

Comments

@MoOx
Copy link
Owner

MoOx commented Apr 27, 2015

Related to #101 with babel-eslint

@jonathanKingston
Copy link
Contributor

I would be interested in helping pick this up to get me into the source unless you are stuck into it? (Just trying to find a way to cut in and help)

@MoOx
Copy link
Owner Author

MoOx commented Apr 30, 2015

This issue is somehow related to #101

Here is the eslint file I am using

---
# babel support more syntax stuff than eslint for now
parser: babel-eslint

ecmaFeatures:
  modules: true

env:
  es6: true
  browser: true
  node: true

# 0: off, 1: warning, 2: error
rules:
  # semicolons are useless
  semi: [2, "never"]

  quotes: [2, "double"]

  # 2 spaces indentation
  indent: [2, 2]

  # trailing coma are cool for diff
  comma-dangle: [2, "always-multiline"]

  # enforce comma at eol (never before)
  comma-style: [2, "last"]

You can take it if you want, cssnext is not that huge (only index.js < 200 lines + test/*)

@jonathanKingston
Copy link
Contributor

Cool yeah I wasn't expecting it to be hard but I just wanted something to work on.

I'd like to get to being as explicit as this too: https://github.com/jonathanKingston/ember-cli-eslint/blob/master/.eslintrc

@MoOx
Copy link
Owner Author

MoOx commented Apr 30, 2015

Your file override lots of default, I like to just define what is modified from default values (most default values of eslint are good enough).

@jonathanKingston
Copy link
Contributor

@MoOx certainly minimum pass is the best. I mostly like to be explicit also just in case the defaults change (yes I am paranoid mostly 😄 ).

Anyway I'll have a go with your set and see if there are any others that might be relevant to enable.

jonathanKingston added a commit to jonathanKingston/cssnext that referenced this issue May 1, 2015
jonathanKingston added a commit to jonathanKingston/cssnext that referenced this issue May 3, 2015
@jonathanKingston
Copy link
Contributor

@MoOx having some trouble getting the tests in master to pass along with the tests here in the work I have done. Looks like a timeout issue rather than an actual issue.
It passes the ESLint rules you specified and no need for babel-eslint with the current code.

@MoOx
Copy link
Owner Author

MoOx commented May 4, 2015

Can you rebase on master (I "fixed" (skipped some) tests for CI) and tell me exactly where is the issue ?

jonathanKingston added a commit to jonathanKingston/cssnext that referenced this issue May 4, 2015
jonathanKingston added a commit to jonathanKingston/cssnext that referenced this issue May 4, 2015
jonathanKingston added a commit to jonathanKingston/cssnext that referenced this issue May 4, 2015
MoOx added a commit that referenced this issue May 4, 2015
Adding in ESLint and fixing basic errors to match #104
@MoOx
Copy link
Owner Author

MoOx commented May 24, 2015

This is good.

@MoOx MoOx closed this as completed May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants