-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace jshint + jscs by eslint #104
Comments
I would be interested in helping pick this up to get me into the source unless you are stuck into it? (Just trying to find a way to cut in and help) |
This issue is somehow related to #101 Here is the eslint file I am using
You can take it if you want, cssnext is not that huge (only index.js < 200 lines + test/*) |
Cool yeah I wasn't expecting it to be hard but I just wanted something to work on. I'd like to get to being as explicit as this too: https://github.com/jonathanKingston/ember-cli-eslint/blob/master/.eslintrc |
Your file override lots of default, I like to just define what is modified from default values (most default values of eslint are good enough). |
@MoOx certainly minimum pass is the best. I mostly like to be explicit also just in case the defaults change (yes I am paranoid mostly 😄 ). Anyway I'll have a go with your set and see if there are any others that might be relevant to enable. |
@MoOx having some trouble getting the tests in master to pass along with the tests here in the work I have done. Looks like a timeout issue rather than an actual issue. |
Can you rebase on master (I "fixed" (skipped some) tests for CI) and tell me exactly where is the issue ? |
Adding in ESLint and fixing basic errors to match #104
This is good. |
Related to #101 with babel-eslint
The text was updated successfully, but these errors were encountered: