This repository has been archived by the owner on Jun 6, 2022. It is now read-only.
Handle case if import with brackets is passed #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Semigradsky @alexgagnon can you please take a look? |
…a into postcss-master
Updates 22 11 2021
Semigradsky
reviewed
Nov 25, 2021
lib/media-ast-from-string.js
Outdated
| * remove spaces after left and before right bracket if spaces exist | ||
| */ | ||
| function trimNearBrackets(string) { | ||
| return string.replace('( ', '(').replace(' )', ')') |
There was a problem hiding this comment.
What if it will be two or more spaces?
There was a problem hiding this comment.
good point!
@alex-knyazev I guess we need trim all spaces
There was a problem hiding this comment.
@Semigradsky fixed, please check, thanks
added 2 commits
February 3, 2022 23:16
handle multiple spaces
|
@jonathantneal can you please take a look? |
|
@Semigradsky can you please take a look? |
lipemat
added a commit
to lipemat/js-boilerplate
that referenced
this pull request
May 17, 2022
Someday the pull request may get merged. Until then we use the fork. csstools/postcss-custom-media#59
lipemat
added a commit
to lipemat/postcss-boilerplate
that referenced
this pull request
May 17, 2022
Someday the pull request may get merged. Until then we use the fork. csstools/postcss-custom-media#59
|
Hi @alex-knyazev, @the-stas, @lipemat, This plugin was moved to the csstools mono repo : https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-custom-media#readme This PR was a great start but we wanted to handle a few more edge cases. |
lipemat
added a commit
to lipemat/js-boilerplate
that referenced
this pull request
Jun 5, 2022
Fix issues with whitespace in `@media( --var )` which previously required a fork. csstools/postcss-custom-media#59 (comment)
lipemat
added a commit
to lipemat/postcss-boilerplate
that referenced
this pull request
Jun 5, 2022
Fixes issues with whitespace in `@media( --var )` which previously required a fork. csstools/postcss-custom-media#59 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.