Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0.0 #43

Merged
merged 1 commit into from
Apr 12, 2020
Merged

9.0.0 #43

merged 1 commit into from
Apr 12, 2020

Conversation

jonathantneal
Copy link
Collaborator

No description provided.

@clarfonthey
Copy link

Why does the project even define a version of sanitize.css in the first place? Sure, the tests can require one, but I don't see why this project cares whether you're on version 10 or 11.

@jonathantneal
Copy link
Collaborator Author

I understand that, and it bothers me to bump this as a major, which is why I stalled. Unfortunately, I’m not sure how to tell this program that it can use whatever version of sanitize.css you are using locally even if the default version is old. Do you have a better idea, @clarfon?

@clarfonthey
Copy link

To me it seems like a peer dependency is what's needed.

@thasmo
Copy link

thasmo commented Nov 22, 2019

@jonathantneal, as @clarfon mentioned, maybe defining as a peer dependency does make sense. And you can still define it as dev dependency if needed for tests or similar.

@jonathantneal jonathantneal force-pushed the release/9.0.0 branch 4 times, most recently from d5f3ac9 to 061eb93 Compare April 12, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants