Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing -ms and -moz css properties #111

Merged
merged 6 commits into from
Nov 25, 2019

Conversation

life777
Copy link
Contributor

@life777 life777 commented Oct 25, 2019

Adds new properties from issue list #50
There are 4 new properties:

  1. -moz-control-character-visibility - I couldn't find any reference to this property in docs and specs. I found only link to bug Mozilla bug tracker where this property was added: https://bugzilla.mozilla.org/show_bug.cgi?id=947588. And w3c emails list with discussions about it: https://lists.w3.org/Archives/Public/www-style/2014Mar/0476.html
  2. -ms-grid-columns and -ms-grid-rows - these two properties are from Grid spec version 0. As I understood they were implemented in IE 10: https://msdn.microsoft.com/en-us/ie/hh772052(v=vs.94). Also I added three new syntaxes: track-group, track-list-v0, and track-minmax. track-list exists in mdn/data, but there is a new version of it which isn't compatible we version 0 for grid-columns and grid-rows properties.
  3. -ms-hyphenate-limit-last - syntax was taken from spec: https://www.w3.org/TR/css-text-4/#hyphenate-line-limits

Thanks

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.456% when pulling a388eb1 on life777:add-missing-css-properties into 7161e8d on csstree:master.

@life777
Copy link
Contributor Author

life777 commented Nov 20, 2019

@lahmatiy Should I change something in this PR or it should be added in MDN data? Thanks

data/patch.json Outdated Show resolved Hide resolved
data/patch.json Outdated Show resolved Hide resolved
data/patch.json Outdated Show resolved Hide resolved
@lahmatiy
Copy link
Member

Sorry for delay in review. Some fixes needed (see above).

@lahmatiy lahmatiy merged commit f8c0cbc into csstree:master Nov 25, 2019
@lahmatiy
Copy link
Member

Thank you!

@life777 life777 deleted the add-missing-css-properties branch November 25, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants