Use const/let instead of var #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahmatiy
reviewed
Dec 13, 2021
| @@ -4,12 +4,12 @@ | |||
| const fixture = []; | |||
|
|
|||
| function test(testcase, mode) { | |||
| var el = document.createElement('div'); | |||
There was a problem hiding this comment.
This module should be written in ES5 to able run it in old browsers without a transpilation. Please, revert changes. You might add a warning comment to avoid the same changes in future (or I will add such a comment by myself).
There was a problem hiding this comment.
Hmmm, the first line (besides imports) has a const, though. I have no idea how the whole thing works. Should I change that to var as well or only revert this file?
There was a problem hiding this comment.
Yes, change for var please. I suppose const works in IE11 somehow and I missed that.
lazarljubenovic
force-pushed
the
prefer-const
branch
from
1a3fbe4
to
ca0a6ba
Compare
|
Whopes, sorry for closing, accidentally pushed no commits. Should be fixed now; I've added the comment as well. |
|
@lazarljubenovic Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.