Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -476,7 +476,7 @@ handle_info({tcp, Socket, Data}, State) -> | |
{noreply, NewState} | ||
end; | ||
handle_info({tcp_closed, Socket}, State=#redis{socket=Socket}) -> | ||
{noreply, State#redis{socket=undefined}}; | ||
{stop, erldis_client_tcp_host_socket_closed, State#redis{socket=undefined}}; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
irr
Author
Contributor
|
||
handle_info(_Info, State) -> | ||
{noreply, State}. | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi!
We noticed that this change changes the behaviour of the client. In our case, the redis server will disconnect the erldis client because it has been inactive for some time. With this change, the erldis client gen_server will crash hard. With the old version, the client will connect again to the redis server when needed.
We would like to understand the reason behind this change, as there might be something important that we are missing.
Thanks
Knut