Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Add more warnings to compile options to increase code quality #48

Closed
orgarten opened this issue Jul 27, 2020 · 0 comments · Fixed by #53
Closed

[ENHANCEMENT] Add more warnings to compile options to increase code quality #48

orgarten opened this issue Jul 27, 2020 · 0 comments · Fixed by #53
Assignees
@orgarten
Labels
enhancement New feature or request

Comments

@orgarten
Copy link
Collaborator

Description

There are plenty of warnings which are currently not caught. We should add at least -Wpedantic and -Wsign-conversion to the warning flags.

Generally, we should aim to catch as many warning as possible. The list can be inspired by https://github.com/lefticus/cpp_starter_project/blob/master/cmake/CompilerWarnings.cmake

Expectation

This will lead to better code quality with fewer (potential) bugs.
@orgarten orgarten added the enhancement New feature or request label Jul 27, 2020
@orgarten orgarten self-assigned this Jul 27, 2020
@orgarten orgarten linked a pull request Jul 28, 2020 that will close this issue
Added many more warning flags and fixed resulting warnings #53
Merged
9 tasks
@cstatz cstatz closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orgarten orgarten

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added many more warning flags and fixed resulting warnings cstatz/blazert
2 participants
@cstatz @orgarten