Added many more warning flags and fixed resulting warnings #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
I added warnings according to this example. The resulting warnings in the code have been fixed and the tests now build without any of the enabled warnings.
I also moved the warnings from the global CMakeLists.txt to the on in
tests, because the library itself is not being compiled and we do not want to bleed all the warnings into people using the library.I added a library target of type
INTERFACEwhich allows for much easier inclusion.While updating doctest, I also updated madmann91/bvh which introduced some minor changes. I fixed our benchmarks accordingly
Type of Change
Checklist