Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect ratio lost in settings #52

Closed
rayzru opened this issue Sep 2, 2016 · 4 comments
Closed

Aspect ratio lost in settings #52

rayzru opened this issue Sep 2, 2016 · 4 comments
Assignees
Milestone

Comments

@rayzru
Copy link
Contributor

rayzru commented Sep 2, 2016

There is some inconsistency in resulted image aspect ratio.
I have played the demo for a while with rectangular images, canvas and rectangular cropped area.
So, actually resulted image sizes have a wrong aspect ratio and it seems like it's value has the sum of the aspect ratio of the crop area and the canvas in general.

(i'll show you plunker later)

Finally, I mean, if I ignore default sizes with similar sizes on each width/height, i will be confused about getting right values on actual result, Settings should be more intuitive and simple.

BTW, i just finished with uploader cropped area via XHR.
It's very simple. we can include this function in future releases if u don't mind,

@jurienhamaker
Copy link
Collaborator

Any updates? Is this still going on?

@ghost
Copy link

ghost commented Oct 4, 2016

Any updates?

@rayzru
Copy link
Contributor Author

rayzru commented Oct 7, 2016

Personally, I think that's bad design to make things from based on a canvas design.

@cstefanache cstefanache added this to the 0.7 milestone Oct 16, 2016
@cstefanache cstefanache self-assigned this Oct 16, 2016
@cstefanache
Copy link
Owner

  • cropWidth:*number - actual cropped image width
  • cropHeight:*number - actual cropped image height

Added ^^^ in order to know the actual cropped image width/height on settings - updated test app as well - will be released today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants