Replace Boost.Regex with the standard library #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was included transitively by Boost.Regex.
We removed the hard dependency on Boost.Regex due to the usage of regex streams when we switched to Boost.JSON. Let's use what the standard library provides instead.
... because `match[idx].str()` is equivalent to `match.str(idx)`.
lzaoral
force-pushed
the
remove-boost-regex
branch
from
9fc787c
to
af890b2
Compare
|
Changing to a draft since EPEL 7 does not provide all |
|
Yeah, this definitely won't work as the regex library was implemented in GCC 4.9 [1] which is newer than GCC in EPEL 7. [1] https://en.cppreference.com/w/cpp/compiler_support/11#C.2B.2B11_library_features |
|
@kdudka Please, let me know in the future when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the hard dependency on Boost.Regex due to the usage of regex streams when we switched to Boost.JSON in #105. Let's use what the standard library provides instead.