parser-cov: accept the [important] flag in checker line
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that it is easier to read and update. No change in behavior intended by this commit. Related: https://issues.redhat.com/browse/OSH-682
... in case someone pastes the text directly from a web browser. For now the parser discards the information about presence of the flag rather than propagating it. This is justified by the fact that the parser should be fed by the data produced by `writer-cov`, which does not produce such a flag. Resolves: https://issues.redhat.com/browse/OSH-682 Closes: csutils#186
kdudka
force-pushed
the
cov-parser-imp-flag
branch
from
2877cdd
to
be42568
Compare
lzaoral
approved these changes
Jun 10, 2024
|
@lzaoral Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in case someone pastes the text directly from a web browser.
For now the parser discards the information about presence of the flag rather than propagating it. This is justified by the fact that the parser should be fed by the data produced by
writer-cov, which does not produce such a flag.Resolves: https://issues.redhat.com/browse/OSH-682