Remove the heapsize dependency. #115
Conversation
src/ingest/buffer.rs
Outdated
| @@ -77,5 +78,9 @@ impl Buffer { | |||
| pub fn len(&self) -> usize { | |||
| self.length | |||
| } | |||
|
|
|||
| pub fn heap_size_of_children(&self) -> usize { | |||
| mem::size_of::<Buffer>() | |||
There was a problem hiding this comment.
This isn't quite right because it will not account for any contents of the buffer HashMap, just the pointer.
I'm fine with just ignoring Buffer completely though (and maybe adding a comment to that extent in Table::heap_size_of_children) since it's not really used at the moment.
|
@cswinter I have update the |
|
@cswinter Missed this point. Updated. |
|
@cswinter I think BTW: The commit tree is a mess. Please squash merge to eliminate such commits. |
src/ingest/raw_val.rs
Outdated
| @@ -23,7 +23,7 @@ impl RawVal { | |||
| match *self { | |||
| RawVal::Int(_) => mem::size_of::<i64>(), | |||
There was a problem hiding this comment.
The i64 would be part of the RawVal, since it does not cause a heap allocation this should just return 0.
|
@cswinter Sorry for that. Previously I am a Java developer. It's not so intuitive for me to distinguish whether a object is on heap or stack. |
|
No worries, there's always more to learn 😄 |
I have removed the heapsize crate in order to build on Max OS X. Moving
heap_size_of_childreninto individual structs'implblocks.Also, I have update the rust-toolchain to 2018-12-31 while rls on Mac is missing in nightly-2018-12-30 version.
https://mexus.github.io/rustup-components-history/x86_64-apple-darwin.html