Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current in-app i18n process handles empty keys poorly #98

Closed
CosmoMyzrailGorynych opened this issue Aug 13, 2019 · 0 comments
Closed

Current in-app i18n process handles empty keys poorly #98

CosmoMyzrailGorynych opened this issue Aug 13, 2019 · 0 comments
Labels
type:enhancement An improvement to an existing functionality

Comments

@CosmoMyzrailGorynych
Copy link
Collaborator

The problem:

  • If a key is absent in the selected translation file, its value will display as undefined. Instead, it should always fallback to English language.
  • If a key's value is an empty string or any onther false-ish variable, it displays as is. It should instead fallback to English language.
  • Existing language files should clear their untranslated keys (rn these are values copied from English.json), so that they become manageable through integrated translation packages (e.g. JSONBabel) (see Existing language files should clear their untranslated keys #97).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement An improvement to an existing functionality
Projects
Archived in project
Development

No branches or pull requests

1 participant