Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom version with setuptools_scm #1333

Closed
maxnoe opened this issue May 15, 2020 · 1 comment
Closed

Replace custom version with setuptools_scm #1333

maxnoe opened this issue May 15, 2020 · 1 comment

Comments

@maxnoe
Copy link
Member

maxnoe commented May 15, 2020

There is an extension for setuptools, which provides the functionality we need and which
integrates nicely with the build system requirements handled by pyproject.toml.

Astropy is are also using this:
https://github.com/astropy/astropy/blob/master/pyproject.toml

@kosack
Copy link
Contributor

kosack commented May 15, 2020

can you explain what this does and if it really replaces what we use? There was a lot of tweaking to get the current system to work correctly with the conda builds, etc, so I would like to avoid changing this until the next version.

@maxnoe maxnoe closed this as completed in 3689b52 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants