Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resurrect option to use fitting in HillasReconstructor #1636

Open
kosack opened this issue Feb 24, 2021 · 0 comments
Open

resurrect option to use fitting in HillasReconstructor #1636

kosack opened this issue Feb 24, 2021 · 0 comments

Comments

@kosack
Copy link
Contributor

kosack commented Feb 24, 2021

Right now, HillasReconstructor loops over pairs of lines, finds their intersection point, and then does a weighted average of the sum (actually doing the cross-product, so the weight is by sin of the angle). Here the weights are for pairs of images.

In MARS (and very old versions of HillasReconstructor), there is the option to use a least-squares fit, which allows one to weight by image, rather than pairs, which can be useful if we want to use weights based on e.g. the MISS parameter.

Re-implementing this fit would be useful, at least as an option, so that we can try different image weighting algorithms.

e.g. something like https://stackoverflow.com/questions/52088966/nearest-intersection-point-to-many-lines-in-python/52089867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant