Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5EventSource only supports image parameters in telescope frame for current files #1922

Closed
maxnoe opened this issue May 25, 2022 · 2 comments
Labels

Comments

@maxnoe
Copy link
Member

maxnoe commented May 25, 2022

Describe the bug

The HDF5EventSource checks the data model version to decide whether to read a HillasParametersContainer or a CameraHillasParametersContainer. This does not support the --camera-frame switch of the current ctapipe-process.

We should either:
a) Handle current files with hillas parameters in camera frame
b) just drop support for hillas parameters in camera frame everywhere

@maxnoe maxnoe added the bug label May 25, 2022
@kosack
Copy link
Contributor

kosack commented May 25, 2022

We could also just drop the --camera-frame option, as it is no longer needed - it was there to be able to test the implementation in the TelescopeFrame, but as that works, we could remove a lot of code.

Edit: just noticed you wrote that already. I'd say let's go for option B

@maxnoe
Copy link
Member Author

maxnoe commented Jan 4, 2023

This was fixed in #2079

@maxnoe maxnoe closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants