Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disp fills table with missing "tel" prefix, results in duplicated columns with and without tel #2441

Closed
maxnoe opened this issue Oct 31, 2023 · 2 comments
Labels

Comments

@maxnoe
Copy link
Member

maxnoe commented Oct 31, 2023

Describe the bug

We made a change to add a _tel between the container prefix and the field name to distinguish mono predictions from stereo predictions when loaded into the same table, code here:
https://github.com/cta-observatory/ctapipe/blob/main/ctapipe/reco/utils.py

We do this also with the per-telescope disp output, which has no stereo equivalent.

The reconstructor is also filling the table without this prefix, so the value with the tel_ prefix is added.

To Reproduce

Run the unit tests for the disp reconstructor, inspect the output:

['disp_parameter_norm',
 'disp_parameter_is_valid',
 'disp_parameter_tel_norm',
 'disp_parameter_tel_is_valid']

Expected behavior

Only have the disp_paremeter_norm and disp_parameter_is_valid columns

@maxnoe maxnoe added the bug label Oct 31, 2023
@Tobychev
Copy link
Contributor

I think this is closed by #2440, right?

@maxnoe
Copy link
Member Author

maxnoe commented Oct 31, 2023

Yes, forgot to link it

@maxnoe maxnoe closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants