Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary support for new CTA r1 data format (EVBv6) #191

Merged
merged 16 commits into from
Jul 6, 2023
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jun 19, 2023

Rebased vs. main isntead of the 0.18.x branch.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 93.05% and project coverage change: +0.74 🎉

Comparison is base (57011d9) 88.74% compared to head (bb6ddb3) 89.48%.

❗ Current head bb6ddb3 differs from pull request most recent head bd5e8ce. Consider uploading reports for the commit bd5e8ce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   88.74%   89.48%   +0.74%     
==========================================
  Files          19       20       +1     
  Lines        1981     2245     +264     
==========================================
+ Hits         1758     2009     +251     
- Misses        223      236      +13     
Impacted Files Coverage Δ
src/ctapipe_io_lst/anyarray_dtypes.py 100.00% <ø> (ø)
src/ctapipe_io_lst/__init__.py 88.62% <81.88%> (-0.70%) ⬇️
src/ctapipe_io_lst/containers.py 100.00% <100.00%> (ø)
src/ctapipe_io_lst/event_time.py 95.54% <100.00%> (+0.65%) ⬆️
src/ctapipe_io_lst/multifiles.py 91.79% <100.00%> (+0.25%) ⬆️
src/ctapipe_io_lst/tests/test_cta_r1.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxnoe maxnoe marked this pull request as ready for review July 3, 2023 09:14
@rlopezcoto
Copy link
Contributor

@maxnoe is this ready to be merged to produce a new release?
I can take care of that of lstchain

@maxnoe
Copy link
Member Author

maxnoe commented Jul 5, 2023

Not really tested on any data actually produced by the EVBv6, only on the artificial data I created in the unit tests, but I think we can go ahead and fix anything when we run into issues.

@maxnoe maxnoe merged commit 273ec6d into main Jul 6, 2023
4 of 5 checks passed
@maxnoe maxnoe deleted the cta_r1_main branch July 6, 2023 07:34
@maxnoe maxnoe changed the title Add support for new CTA r1 data format (EVBv6) Add preliminary support for new CTA r1 data format (EVBv6) Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants