Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI upload doesn't work anymore #191

Open
HealthyPear opened this issue Apr 19, 2022 · 2 comments
Open

PyPI upload doesn't work anymore #191

HealthyPear opened this issue Apr 19, 2022 · 2 comments
Labels
bug Something isn't working maintenance
Milestone

Comments

@HealthyPear
Copy link
Member

The new release v0.5.0 is not on PyPI.

Debugging the problem I can see that in the first attempt the uploaded version results in v0.0.0 which is of course wrong
https://github.com/cta-observatory/protopipe/actions/runs/2168145005/attempts/1

I think the problem is that setuptools_scm is not supported by the current deploy workflow, which is in fact different from that of ctapipe (the last but one release was so old that this was not a problem...)
https://github.com/cta-observatory/ctapipe/blob/0612a333c87cbb7c39b3a82c4663082e77eceb72/.github/workflows/deploy.yml#L22-L26

@HealthyPear HealthyPear added bug Something isn't working maintenance labels Apr 19, 2022
@HealthyPear HealthyPear added this to Needs triage in Bugs and wrong behaviours via automation Apr 19, 2022
@HealthyPear HealthyPear added this to To do in Maintenance via automation Apr 19, 2022
@kosack
Copy link
Contributor

kosack commented Apr 19, 2022

opened #192 to attempt to fix this

@HealthyPear
Copy link
Member Author

the problem is that the workflow gets triggered only by a tag pushed as "v*" (a release with this name triggers it)

that PR alone won't cut it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance
Projects
Bugs and wrong behaviours
  
High priority
Maintenance
  
To do
Development

No branches or pull requests

2 participants