Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to make build.yml work #192

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Conversation

kosack
Copy link
Contributor

@kosack kosack commented Apr 19, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #192 (bd2f66b) into master (926d68d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   63.11%   63.11%           
=======================================
  Files          28       28           
  Lines        2890     2890           
=======================================
  Hits         1824     1824           
  Misses       1066     1066           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926d68d...bd2f66b. Read the comment docs.

Just makes it less error prone
@HealthyPear
Copy link
Member

better merge this after the changelog has been update (remember that the draft will be overwritten anytime a new PR is merged - only the template defined in https://github.com/cta-observatory/protopipe/blob/master/.github/release-drafter.yml will survive and will need to be edited according to the previous release format - unless you want to change it, but I'd prefer to leave al least the last release with my contribution in this way)

@kosack
Copy link
Contributor Author

kosack commented Apr 19, 2022

it only runs on releases, right? So it shouldn't matter if we merge it first. Or does it run even on PRs?

@HealthyPear
Copy link
Member

it only runs on releases, right? So it shouldn't matter if we merge it first. Or does it run even on PRs?

I meant that the changelog will be overwritten/updated, so you should copy somewhere anything that might get lost there and update it in that PR

@HealthyPear HealthyPear merged commit 2373f9a into cta-observatory:master Apr 19, 2022
@HealthyPear HealthyPear added the fix A PR that fixes a bug or a wrong behaviour. label Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A PR that fixes a bug or a wrong behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants