You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The latest working version of gammapy for protopipe is 0.8, which could be quite old for some people.
With gammapy 0.10 came PR #1998: a change was made to the class SensitivityEstimator for which the keyword irf was dropped.
This breaks behavior in protopipe, which instead uses it.
Indeed, when launching the script make_performance.py the user gets the following error,
### Estimating sensitivity... Traceback (most recent call last): File "/Users/michele/Applications/ctasoft/protopipe/protopipe/scripts/make_performance.py", line 185, in <module> main() File "/Users/michele/Applications/ctasoft/protopipe/protopipe/scripts/make_performance.py", line 181, in main sensitivity_maker.estimate_sensitivity() File "/Users/michele/Applications/ctasoft/protopipe/protopipe/perf/irf_maker.py", line 101, in estimate_sensitivity sensitivity_estimator = SensitivityEstimator(irf=self.irf, livetime=obs_time) TypeError: __init__() got an unexpected keyword argument 'irf'
So if we want to let protopipe use the latest version of gammapy (provided that this will not break anything else, of course), at least line #101 in protopipe/protopipe/perf/irf_maker.py will need to be updated accordingly.
The text was updated successfully, but these errors were encountered:
they seem to split the IRF into the arf, rmf, and bkg components.
I would suggest either:
update the dependencies to require gammapy=~0.10 (compatible with 0.10 - or better 0.14, since that's the latest) and update the function to call it correctly (passing in the tables separately).
or just make sure the current requirements fix the gammapy version to the old version
The latest working version of gammapy for protopipe is 0.8, which could be quite old for some people.
With gammapy 0.10 came PR #1998: a change was made to the class SensitivityEstimator for which the keyword irf was dropped.
This breaks behavior in protopipe, which instead uses it.
Indeed, when launching the script make_performance.py the user gets the following error,
### Estimating sensitivity... Traceback (most recent call last): File "/Users/michele/Applications/ctasoft/protopipe/protopipe/scripts/make_performance.py", line 185, in <module> main() File "/Users/michele/Applications/ctasoft/protopipe/protopipe/scripts/make_performance.py", line 181, in main sensitivity_maker.estimate_sensitivity() File "/Users/michele/Applications/ctasoft/protopipe/protopipe/perf/irf_maker.py", line 101, in estimate_sensitivity sensitivity_estimator = SensitivityEstimator(irf=self.irf, livetime=obs_time) TypeError: __init__() got an unexpected keyword argument 'irf'
So if we want to let protopipe use the latest version of gammapy (provided that this will not break anything else, of course), at least line #101 in protopipe/protopipe/perf/irf_maker.py will need to be updated accordingly.
The text was updated successfully, but these errors were encountered: