Towards using Pyirf

[gaia-verna]

Related to first point in #73

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[HealthyPear]

Many of the files complain that there is no newline at the end.
Honestly, I don't know if this is important, but just to be sure please add them so at least the red signs disappear

[HealthyPear]

Also, maybe add a couple of lines in the docs under perf about these changes

[gaia-verna]

We will update the docs in the next PR in which we plan to add the script to produce the performance using pyirf

[HealthyPear]

Remember to update the EventDisplay main part from pyirf example once the new release is out, because we have recently updated it

[gaia-verna]

Remember to update the EventDisplay main part from pyirf example once the new release is out, because we have recently updated it

Yes we will do it in the next PR because here we are not uploaded the make_performance_pyirf file

[HealthyPear]

Remember to update the EventDisplay main part from pyirf example once the new release is out, because we have recently updated it

Yes we will do it in the next PR because here we are not uploaded the make_performance_pyirf file

Sorry my bad - I had forgot the scope of this PR

[HealthyPear]

Please, first merge master into this PR and try to solve the (merge conflicts, hopefully, few and small).
Generally your changes should supersede mine.

I left here and there various changes to revert/add.
If you have any doubt, please contact me!

[codecov]

Codecov Report

Merging #79 (9f67772) into master (d7a9b90) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   30.91%   30.78%   -0.13%     
==========================================
  Files          20       20              
  Lines        2258     2267       +9     
==========================================
  Hits          698      698              
- Misses       1560     1569       +9     

Impacted Files	Coverage Δ
protopipe/perf/cut_optimisation.py	9.68% <0.00%> (+0.08%)	⬆️
protopipe/perf/irf_maker.py	14.49% <0.00%> (ø)
protopipe/scripts/make_performance.py	10.75% <0.00%> (ø)
protopipe/scripts/write_dl2.py	5.63% <0.00%> (-0.27%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a9b90...9f67772. Read the comment docs.