Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison with EventDisplay : Calibration #86

Open
HealthyPear opened this issue Dec 1, 2020 · 12 comments
Open

Comparison with EventDisplay : Calibration #86

HealthyPear opened this issue Dec 1, 2020 · 12 comments
Labels
benchmarks enhancement New feature or request summary A summary of issues related to the same subject

Comments

@HealthyPear
Copy link
Member

HealthyPear commented Dec 1, 2020

This is sub-summary issue part of #85 .

Requirements

TBD

Reference documents

  • Prod3b IRF report (link)
  • Benchmarks (benchmarks/DL1/benchmarks_DL1_calibration.ipynb)

Known sources of possible divergence and current status:

  • TBD
@HealthyPear HealthyPear added enhancement New feature or request summary A summary of issues related to the same subject benchmarks labels Dec 1, 2020
@HealthyPear
Copy link
Member Author

@GernotMaier here there should not be big differences, taking into account that the extractor that CTAMARS uses came from VERITAS.

To summarise

  • gain selection from high to low channel via a threshold of N ADC counts (where N is configurable, default is 4000 waveform sample units)
  • image extraction as explained in the docstring here - the default preliminary cleaning thresholds are (6,3) for LSTCam, (8,4) for NectarCam, (4, 2) for SSTs (dummy values)

Any major differences wrt to what EventDisplay does?

@GernotMaier
Copy link

Major difference is obviously the image cleaning methods applied. Eventdisplay uses the optimised next-neighbour cleaning (https://ui.adsabs.harvard.edu/abs/2013ICRC...33.3000S/abstract).

@HealthyPear
Copy link
Member Author

This is an issue which I dedicated to the calibration phase - do you mean that you use this cleaning also in the middle of the 2 image extraction passes?

@GernotMaier
Copy link

trying to understand what 'in the middle of the two image extraction passes' means. You refer to the double pass cleaning from VERITAS? I don't use this for CTA but only do a single pass cleaning using Maxim's cleaning method.

@HealthyPear
Copy link
Member Author

Yes, I mean the cleaning that is used in the CTAMARS version between 1st pass and 2nd pass.

So you do not use a double-pass image extraction.
Does the document you link above describe also image extraction or only the cleaning afterward? In the latter case, can you point me to the document that describes the image extraction procedure you use in EventDisplay? (perhaps the references from your repo?)

@GernotMaier
Copy link

I thought image extraction == image cleaning...do you mean the trace integration step or what do you call image extraction?

@HealthyPear
Copy link
Member Author

I call image extraction the process that translates ADC counts (or anyway sample units of the waveform) to phe which results in calibrated images which will after get cleaned and parametrized to DL1

what is a bit confusing is that in the 2-pass image extraction of CTAMARS there is a preliminary image cleaning, but the whole process is image extraction

@GernotMaier
Copy link

OK. So signal extraction is simply a sliding window searching for the maximum integrated ADC counts, followed by the image cleaning described in the document above.

@HealthyPear
Copy link
Member Author

How large is this window in sample units?

@GernotMaier
Copy link

Depends on the telescope type and the typical width of the pulse shapes.

For prod5, this is LST: 2, MST-F: 4, MST-N 4, SST: 6

Note that I up-sample the FlashCam traces by a factor of 4 (using the code provided by the FlashCam team)

@HealthyPear
Copy link
Member Author

I never tested cameras outside LSTCam and NectarCam, so good to know!

Any chance you can pass me these same numbers for e.g. Prod3b baseline (North & South)?

I promise I'll start Prod5...

@GernotMaier
Copy link

for prod3b:

  • LST: 4
  • MST-N: 6
  • MST-F: 4
  • GC-SST: 8
  • SST-1M: 6
  • ASTRi-SST: 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks enhancement New feature or request summary A summary of issues related to the same subject
Projects
None yet
Development

No branches or pull requests

2 participants