Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrongly plotted data in average single-pixel spectra #98

Closed
HealthyPear opened this issue Feb 2, 2021 · 0 comments · Fixed by #99
Closed

Wrongly plotted data in average single-pixel spectra #98

HealthyPear opened this issue Feb 2, 2021 · 0 comments · Fixed by #99
Labels
benchmarks wrong behaviour The code works but produces clearly wrong results
Projects
Bugs and wrong behaviours
Milestone
v0.4.0

Comments

@HealthyPear
Copy link
Member

Data related to 2nd pass reconstructed values associated to simulated "signal" and "noise" true pixels (separately) are currently built from incorrect data.

From a simplified version, I recovered the correct results, which I put already here for preliminary information.
This doesn't seem to influence the calculated values of the optimized cleaning thresholds - checks will follow.

LST_LST_LSTCam

MST_MST_NectarCam
@HealthyPear HealthyPear added wrong behaviour The code works but produces clearly wrong results benchmarks labels Feb 2, 2021
@HealthyPear HealthyPear added this to the v0.4.0 milestone Feb 2, 2021
@HealthyPear HealthyPear added this to Needs triage in Bugs and wrong behaviours via automation Feb 2, 2021
@HealthyPear HealthyPear moved this from Needs triage to Low priority in Bugs and wrong behaviours Feb 2, 2021
@HealthyPear HealthyPear mentioned this issue Feb 3, 2021
Merged
Bugs and wrong behaviours automation moved this from Low priority to Closed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmarks wrong behaviour The code works but produces clearly wrong results
Projects
Bugs and wrong behaviours
  
Closed
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Fix plot of simulated signal and noise of 2nd pass image extraction HealthyPear/protopipe
1 participant
@HealthyPear