Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot of simulated signal and noise of 2nd pass image extraction #99

Conversation

HealthyPear
Copy link
Member

Closes #98

@HealthyPear HealthyPear added fix A PR that fixes a bug or a wrong behaviour. benchmarks labels Feb 3, 2021
@HealthyPear HealthyPear added this to the v0.4.0 milestone Feb 3, 2021
@HealthyPear HealthyPear added this to In progress in Bugs and wrong behaviours via automation Feb 3, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #99 (10faeb4) into master (e8a51f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   36.81%   36.81%           
=======================================
  Files          18       18           
  Lines        1798     1798           
=======================================
  Hits          662      662           
  Misses       1136     1136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a51f1...0d7813e. Read the comment docs.

@HealthyPear HealthyPear merged commit 5b2a815 into cta-observatory:master Feb 4, 2021
Bugs and wrong behaviours automation moved this from In progress to Closed Feb 4, 2021
@HealthyPear HealthyPear deleted the fix-calibration-benchmark-plot-signal-noise-2ndPass branch February 4, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks fix A PR that fixes a bug or a wrong behaviour.
Projects
Development

Successfully merging this pull request may close these issues.

Wrongly plotted data in average single-pixel spectra
2 participants